Re: [PATCH v1 03/10] xhci: dbc: Use sysfs_emit() to instead of scnprintf()
From: kernel test robot
Date: Mon Oct 02 2023 - 15:09:54 EST
Hi Andy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus linus/master v6.6-rc4 next-20230929]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/xhci-dbc-Convert-to-use-sysfs_streq/20231003-002032
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20231002161610.2648818-3-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 03/10] xhci: dbc: Use sysfs_emit() to instead of scnprintf()
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231003/202310030150.M1SfrYmG-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231003/202310030150.M1SfrYmG-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310030150.M1SfrYmG-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/usb/host/xhci-dbgcap.c: In function 'dbc_show':
>> drivers/usb/host/xhci-dbgcap.c:926:34: warning: unused variable 'p' [-Wunused-variable]
926 | const char *p;
| ^
vim +/p +926 drivers/usb/host/xhci-dbgcap.c
60f4451ef37351 Andy Shevchenko 2023-10-02 921
dfba2174dc421e Lu Baolu 2017-12-08 922 static ssize_t dbc_show(struct device *dev,
dfba2174dc421e Lu Baolu 2017-12-08 923 struct device_attribute *attr,
dfba2174dc421e Lu Baolu 2017-12-08 924 char *buf)
dfba2174dc421e Lu Baolu 2017-12-08 925 {
dfba2174dc421e Lu Baolu 2017-12-08 @926 const char *p;
dfba2174dc421e Lu Baolu 2017-12-08 927 struct xhci_dbc *dbc;
dfba2174dc421e Lu Baolu 2017-12-08 928 struct xhci_hcd *xhci;
dfba2174dc421e Lu Baolu 2017-12-08 929
dfba2174dc421e Lu Baolu 2017-12-08 930 xhci = hcd_to_xhci(dev_get_drvdata(dev));
dfba2174dc421e Lu Baolu 2017-12-08 931 dbc = xhci->dbc;
dfba2174dc421e Lu Baolu 2017-12-08 932
60f4451ef37351 Andy Shevchenko 2023-10-02 933 if (dbc->state >= ARRAY_SIZE(dbc_state_strings))
60f4451ef37351 Andy Shevchenko 2023-10-02 934 return sysfs_emit(buf, "unknown\n");
dfba2174dc421e Lu Baolu 2017-12-08 935
60f4451ef37351 Andy Shevchenko 2023-10-02 936 return sysfs_emit(buf, "%s\n", dbc_state_strings[dbc->state]);
dfba2174dc421e Lu Baolu 2017-12-08 937 }
dfba2174dc421e Lu Baolu 2017-12-08 938
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki