Re: [PATCH v2 3/4] trigger: ledtrig-tty: move variable definition to the top

[Jiri Slaby]

On 02. 10. 23, 16:05, Lee Jones wrote:
> On Thu, 28 Sep 2023, Florian Eckert wrote:
>
> > The Intel build robot has complained about this. Hence move the commit
> > of the variable definition to the beginning of the function.
>
> Please copy the robot's error message into the commit message.

Ah, lkp, then also the Closes: line as it suggests.

> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Florian Eckert <fe@xxxxxxxxxx>
> > ---
> >   drivers/leds/trigger/ledtrig-tty.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/leds/trigger/ledtrig-tty.c b/drivers/leds/trigger/ledtrig-tty.c
> > index 8ae0d2d284af..1c6fadf0b856 100644
> > --- a/drivers/leds/trigger/ledtrig-tty.c
> > +++ b/drivers/leds/trigger/ledtrig-tty.c
> > @@ -82,6 +82,7 @@ static void ledtrig_tty_work(struct work_struct *work)
> >   {
> >   	struct ledtrig_tty_data *trigger_data =
> >   		container_of(work, struct ledtrig_tty_data, dwork.work);
> > +	unsigned long interval = LEDTRIG_TTY_INTERVAL;
> >   	struct serial_icounter_struct icount;
> >   	int ret;
> >   
> > @@ -124,8 +125,6 @@ static void ledtrig_tty_work(struct work_struct *work)
> >   
> >   	if (icount.rx != trigger_data->rx ||
> >   	    icount.tx != trigger_data->tx) {
> > -		unsigned long interval = LEDTRIG_TTY_INTERVAL;
> > -
> >   		led_blink_set_oneshot(trigger_data->led_cdev, &interval,
> >   				      &interval, 0);
> >   
> > --
> > 2.30.2

--
js
suse labs