Re: [EXT] Re: [PATCH 1/7] dt-bindings: arm: coresight-tmc: Add "memory-region" property

[Krzysztof Kozlowski]

On 03/10/2023 06:33, Linu Cherian wrote:
> Hi Krzysztof,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> Sent: Saturday, September 30, 2023 8:59 PM
>> To: Linu Cherian <lcherian@xxxxxxxxxxx>; suzuki.poulose@xxxxxxx;
>> mike.leach@xxxxxxxxxx; james.clark@xxxxxxx; leo.yan@xxxxxxxxxx
>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; coresight@xxxxxxxxxxxxxxxx; linux-
>> kernel@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx;
>> krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx;
>> devicetree@xxxxxxxxxxxxxxx; Sunil Kovvuri Goutham
>> <sgoutham@xxxxxxxxxxx>; George Cherian <gcherian@xxxxxxxxxxx>
>> Subject: [EXT] Re: [PATCH 1/7] dt-bindings: arm: coresight-tmc: Add
>> "memory-region" property
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> On 29/09/2023 15:37, Linu Cherian wrote:
>>> memory-region 0: Reserved trace buffer memory
>>>
>>>   TMC ETR: When available, use this reserved memory region for
>>>   trace data capture. Same region is used for trace data
>>>   retention after a panic or watchdog reset.
>>>
>>>   TMC ETF: When available, use this reserved memory region for
>>>   trace data retention synced from internal SRAM after a panic or
>>>   watchdog reset.
>>>
>>> memory-region 1: Reserved meta data memory
>>>
>>>   TMC ETR, ETF: When available, use this memory for register
>>>   snapshot retention synced from hardware registers after a panic
>>>   or watchdog reset.
>>>
>>> Signed-off-by: Linu Cherian <lcherian@xxxxxxxxxxx>
>>> ---
>>
>> Where is the changelog? This is supposed to be v4 or something later.
>> Please, keep proper versioning and changelog.
> 
> Sure, will add the changelog from next version onwards. 
> 
> Yeah, the last version was RFC v3 and the RFC tag has been dropped from this version onwards.
> Hence started this version with V1.

v1 says it is the first version, but you already had three others.
Please keep continuous version log, regardless whether you call it RFC
or RFT or RFsomething.

> 
>>
>>>  .../bindings/arm/arm,coresight-tmc.yaml       | 19 +++++++++++++++++++
>>>  1 file changed, 19 insertions(+)
>>>

Best regards,
Krzysztof