Re: [PATCH v2] dt-bindings: phy: Convert PXA1928 USB/HSIC PHY to DT schema

[Krzysztof Kozlowski]

On 02/10/2023 21:34, Duje Mihanović wrote:
> Convert the binding for the Marvell PXA1928 USB and HSIC PHYs from TXT
> to DT schema.
> 
> Signed-off-by: Duje Mihanović <duje.mihanovic@xxxxxxxx>
> ---
> Changes in v2:
> - Add myself as maintainer
> - Combine HSIC and USB bindings into one
> - Drop unneeded quotes
> - Remove example as it can't compile (probably because of clock
>   reference)
> - Link to v1: https://lore.kernel.org/r/20231001-pxa1928-usb-yaml-v1-1-9309a8c0c03f@xxxxxxxx

Thank you for your patch. There is something to discuss/improve.


> +++ b/Documentation/devicetree/bindings/phy/marvell,pxa1928-usb-phy.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/marvell,pxa1928-usb-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PXA1928 USB/HSIC PHY
> +
> +maintainers:
> +  - Duje Mihanović <duje.mihanovic@xxxxxxxx>
> +
> +properties:
> +  $nodename:
> +    pattern: '^phy@[a-f0-9]+$'

Drop nodename, we do no need enforce in each device schemas.

> +
> +  compatible:
> +    oneOf:
> +      - items:
> +          const: marvell,pxa1928-usb-phy
> +      - items:
> +          const: marvell,pxa1928-hsic-phy

Entire oneOf is just an enum (without items, no const):
enum:
  - foo
  - bar

> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  '#phy-cells':
> +    const: 0
> +
> +  resets:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - '#phy-cells'
> +
> +additionalProperties: false

Please add example DTS.

Best regards,
Krzysztof