Re: [PATCH v1 1/2] pinctrl: baytrail: drop runtime PM support
From: Raag Jadav
Date: Tue Oct 03 2023 - 05:05:44 EST
On Tue, Oct 03, 2023 at 01:45:18PM +0530, Raag Jadav wrote:
> Since Baytrail pinctrl device is not attached to acpi_lpss_pm_domain,
> runtime PM serves no purpose here. Drop it and switch to pm_sleep_ptr()
> as now we only have suspend and resume handles in place.
>
> No functional impact.
>
> TODO:
> Consider moving to DEFINE_LATE_DEV_PM_OPS() in the future once we have
> enough users to account for its introduction.
>
> Signed-off-by: Raag Jadav <raag.jadav@xxxxxxxxx>
> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> ---
> drivers/pinctrl/intel/pinctrl-baytrail.c | 18 +-----------------
> 1 file changed, 1 insertion(+), 17 deletions(-)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
> index ec76e43527c5..14a61a262be1 100644
> --- a/drivers/pinctrl/intel/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
> @@ -16,7 +16,6 @@
> #include <linux/module.h>
> #include <linux/types.h>
> #include <linux/platform_device.h>
> -#include <linux/pm_runtime.h>
> #include <linux/property.h>
> #include <linux/seq_file.h>
> #include <linux/string_helpers.h>
I just realized I forgot to add pm.h here.
I'll send out a v2.
Raag