Re: [PATCH v5 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver

From: Andy Shevchenko
Date: Tue Oct 03 2023 - 06:50:20 EST


On Mon, Oct 2, 2023 at 11:06 PM Tomer Maimon <tmaimon77@xxxxxxxxx> wrote:
>
> Add Nuvoton NPCM BMC sdhci-pltfm controller driver.

FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

...

> +static const struct of_device_id npcm_sdhci_of_match[] = {
> + { .compatible = "nuvoton,npcm750-sdhci", .data = &npcm7xx_sdhci_pdata, },
> + { .compatible = "nuvoton,npcm845-sdhci", .data = &npcm8xx_sdhci_pdata, },

Only in case when you need a new version, you may remove the inner
trailing commas,
no need to do this right now.

> + { }
> +};

--
With Best Regards,
Andy Shevchenko