Re: [PATCH v6 1/3] dt-bindings: Add beaglecc1352
From: Ayush Singh
Date: Tue Oct 03 2023 - 08:47:58 EST
+
+ reset-gpios:
+ maxItems: 1
+
+ power-gpios:
+ maxItems: 3
+ description:
+ The device has three power rails that are exposed on external pins VDDS,
+ VDDR and DCOUPL.
Shouldn't these be regulators? The power rails are input to the MCU,
correct?
The properties should be something like:
vdds-supply
vddr-supply
dcoupl-supply ? (not sure what dcoupl is, but description should provide
that info).
the gpio controls for those can be modelled by regulator-gpio ?
I picked up power lines from "CC13xx/CC26xx Hardware Configuration and
PCB Design Considerations Application Report" present under "8.14
Network Processor" of CC1352P7 data sheet.
But now looking closer, it doesn't seem like DCOUPL can be supplied
externally for CC1352P7 and thus should probably be removed.
Also, it seems like for CC1352P7, VDDR must always be supplied
internally (The data sheet states: "Internal supply, must be powered
from the internal DC/DC converter or the internal LDO"). Thus, it should
be safe to remove VDDR as well.
That means only VDDS needs to be present for power line.
CC13xx/CC26xx Hardware Configuration and PCB Design Considerations
Application Report: https://www.ti.com/lit/pdf/swra640
CC1352P7 Data sheet: https://www.ti.com/lit/gpn/CC1352P7
Sincerely,
Ayush Singh