Re: [PATCH 03/29] 9p: move xattr-related structs to .rodata

[Wedson Almeida Filho]

On Sat, 30 Sept 2023 at 06:03, Dominique Martinet
<asmadeus@xxxxxxxxxxxxx> wrote:
>
> Christian Schoenebeck wrote on Sat, Sep 30, 2023 at 10:12:25AM +0200:
> > On Saturday, September 30, 2023 7:00:07 AM CEST Wedson Almeida Filho wrote:
> > > From: Wedson Almeida Filho <walmeida@xxxxxxxxxxxxx>
> > >
> > > This makes it harder for accidental or malicious changes to
> > > v9fs_xattr_user_handler, v9fs_xattr_trusted_handler,
> > > v9fs_xattr_security_handler, or v9fs_xattr_handlers at runtime.
> > >
> > > Cc: Eric Van Hensbergen <ericvh@xxxxxxxxxx>
> > > Cc: Latchesar Ionkov <lucho@xxxxxxxxxx>
> > > Cc: Dominique Martinet <asmadeus@xxxxxxxxxxxxx>
> > > Cc: Christian Schoenebeck <linux_oss@xxxxxxxxxxxxx>
> > > Cc: v9fs@xxxxxxxxxxxxxxx
> > > Signed-off-by: Wedson Almeida Filho <walmeida@xxxxxxxxxxxxx>
> >
> > Reviewed-by: Christian Schoenebeck <linux_oss@xxxxxxxxxxxxx>

Thanks for the review, Christian!

> Looks good to me on principle as well (and it should blow up immediately
> on testing in the unlikely case there's a problem...)
>
> Eric, I don't think you have anything planned for this round?
> There's another data race patch laying around that we didn't submit for
> 6.6, shall I take these two for now?
>
> (Assuming this patch series is meant to be taken up by individual fs
> maintainers independantly, it's never really clear with such large
> swatches of patchs and we weren't in Cc of a cover letter if there was
> any... In the future it'd help if either there's a clear cover letter
> everyone is in Cc at (some would say keep everyone in cc of all
> patches!), or just send these in a loop so they don't appear to be part
> of a series and each maintainer deals with it as they see fit)

There is a cover letter
(https://lore.kernel.org/all/20230930050033.41174-1-wedsonaf@xxxxxxxxx/),
apologies for not CCing you there. I was trying to avoid spamming
maintainers with unrelated changes.

We need changes in fs/xattr.c (which are in the first patch of the
series) to avoid warnings, so unfortunately this can't be taken
individually. My thought was that individual fs maintainers would
review/ack the patches and this would be taken through the fs tree.

>
> --
> Dominique