Re: [PATCH 4/8] dt-bindings: usb: dwc3: Add clocks on Qualcomm IPQ5332

[Praveenkumar I]

On 9/30/2023 10:53 PM, Dmitry Baryshkov wrote:
> On 29/09/2023 11:42, Praveenkumar I wrote:
> > Add aux and lfps clocks in Qualcomm IPQ5332. These clocks are required
> > for USB Super-Speed support.
> >
> > Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/usb/qcom,dwc3.yaml    | 20 ++++++++++++++++++-
> >   1 file changed, 19 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml 
> > b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > index 67591057f234..18af2887b984 100644
> > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > @@ -149,6 +149,25 @@ allOf:
> >               - const: sleep
> >               - const: mock_utmi
> >   +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - qcom,ipq5332-dwc3
> > +    then:
> > +      properties:
> > +        clocks:
> > +          maxItems: 6
> > +        clock-names:
> > +          items:
> > +            - const: core
> > +            - const: iface
> > +            - const: sleep
> > +            - const: mock_utmi
> > +            - const: aux
> > +            - const: lfps
>
> Could you please also describe the lfps clock in the top-level clocks 
> entry?
Sure, will add.
> > +
> >     - if:
> >         properties:
> >           compatible:
> > @@ -238,7 +257,6 @@ allOf:
> >           compatible:
> >             contains:
> >               enum:
> > -              - qcom,ipq5332-dwc3
> >                 - qcom,msm8994-dwc3
> >                 - qcom,qcs404-dwc3
> >       then:
--
Thanks,
Praveenkumar