Re: [PATCH 02/36] pinctrl: provide new GPIO-to-pinctrl glue helpers
From: Andy Shevchenko
Date: Tue Oct 03 2023 - 11:10:41 EST
On Tue, Oct 3, 2023 at 6:08 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Tue, Oct 3, 2023 at 5:51 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
...
> > + * pinctrl_gpio_request_new() - request a single pin to be used as GPIO
>
> "new" is too broad and too odd suffix, what I would see as a better
> alternative(s) is (are):
>
> pinctrl_gpiochip_request()
> pinctrl_gpio_chip_request()
> pinctrl_gc_request()
>
> (sorted by personal preference from high to low).
>
> The similar comment to all of them.
Or since it's about the GPIO line
pinctrl_gpio_line_request()
(and other variants near to this).
--
With Best Regards,
Andy Shevchenko