Re: [PATCH] extract and use FILE_LINE macro

[Alexey Dobriyan]

On Mon, Oct 02, 2023 at 10:33:49AM -0700, Kees Cook wrote:
> > +#define FILE_LINE	__FILE__ ":" __stringify(__LINE__)
> > +
> >  #endif	/* !__LINUX_STRINGIFY_H */

> > --- a/sound/pci/asihpi/hpidebug.h
> > +++ b/sound/pci/asihpi/hpidebug.h
> > @@ -29,16 +29,15 @@ enum { HPI_DEBUG_LEVEL_ERROR = 0,	/* always log errors */
> >     the start of each message, eg see linux kernel hpios.h */
> >  
> >  #ifdef SOURCEFILE_NAME
> > +#undef FILE_LINE
> >  #define FILE_LINE  SOURCEFILE_NAME ":" __stringify(__LINE__) " "
> 
> Should this drop the trailing " " to match the new macro?

Yes, probably. This SOURCEFILE_NAME is some out of tree stuff.