Re: [PATCH v6] perf: arm_cspmu: Separate Arm and vendor module

[Suzuki K Poulose]

Hi Besar

On 03/10/2023 15:20, Besar Wicaksono wrote:
> Thanks Ilkka.
> Suzuki/Robin, can we have someone from Arm to review this patch ? It's been a while.

Apologies for the delay.

> Regards,
> Besar
>
> > -----Original Message-----
> > From: Ilkka Koskinen <ilkka@xxxxxxxxxxxxxxxxxxxxxx>
> > Sent: Thursday, September 14, 2023 1:19 PM
> > To: Besar Wicaksono <bwicaksono@xxxxxxxxxx>
> > Cc: suzuki.poulose@xxxxxxx; robin.murphy@xxxxxxx;
> > ilkka@xxxxxxxxxxxxxxxxxxxxxx; catalin.marinas@xxxxxxx; will@xxxxxxxxxx;
> > mark.rutland@xxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx; Thierry Reding
> > <treding@xxxxxxxxxx>; Jonathan Hunter <jonathanh@xxxxxxxxxx>; Vikram
> > Sethi <vsethi@xxxxxxxxxx>; Richard Wiley <rwiley@xxxxxxxxxx>; Eric Funsten
> > <efunsten@xxxxxxxxxx>
> > Subject: Re: [PATCH v6] perf: arm_cspmu: Separate Arm and vendor module
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Hi Besar,
> >
> > On Mon, 21 Aug 2023, Besar Wicaksono wrote:
> > > Arm Coresight PMU driver consists of main standard code and
> > > vendor backend code. Both are currently built as a single module.
> > > This patch adds vendor registration API to separate the two to
> > > keep things modular. The main driver requests each known backend
> > > module during initialization and defer device binding process.
> > > The backend module then registers an init callback to the main
> > > driver and continue the device driver binding process.
> > >
> > > Signed-off-by: Besar Wicaksono <bwicaksono@xxxxxxxxxx>
> >
> > I tested the patch with AmpereOne patchset on top of it and it seemed to
> > work fine. In addition, the patch looks good to me.
> >
> > Reviewed-and-tested-by: Ilkka Koskinen <ilkka@xxxxxxxxxxxxxxxxxxxxxx>
> >
> >
> > Cheers, Ilkka
> >
> > > ---
> > >
> > > Changes from v5:
> > > * Incorporate review comments.
> > > * Fix arm_cspmu_impl_match_get not returning NULL if no matching impl.
> > > * Fix impl_match.module may reset when registering PMU.
> > > * Maintain backend module ref count until PMU registration is done.
> > > Thanks to Will, Suzuki, and Robin for the feedback.
> > > v5: https://lore.kernel.org/linux-arm-kernel/20230705104745.52255-1-
> > bwicaksono@xxxxxxxxxx/T/#u

The changes to address the comments from v5, looks good to me. Thanks
for fixing them.

Reviewed-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>