Re: [PATCH v2 1/2] mm: memcg: refactor page state unit helpers
From: Michal Koutný
Date: Tue Oct 03 2023 - 14:11:10 EST
On Fri, Sep 22, 2023 at 05:57:39PM +0000, Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote:
> memcg_page_state_unit() is currently used to identify the unit of a
> memcg state item so that all stats in memory.stat are in bytes. However,
> it lies about the units of WORKINGSET_* stats. These stats actually
> represent pages, but we present them to userspace as a scalar number of
> events. In retrospect, maybe those stats should have been memcg "events"
> rather than memcg "state".
Why isn't it possible to move WORKINGSET_* stats under the events now?
(Instead of using internal and external units.)
Thanks,
Michal
Attachment:
signature.asc
Description: PGP signature