Re: [PATCH] Input: elantech - fix fast_reconnect callback in ps2 mode

[Thorsten Leemhuis]

On 04.10.23 02:57, Jeffery Miller wrote:
> Make `elantech_setup_ps2` set a compatible fast_reconnect pointer
> when its ps2 mode is used.
> 
> When an SMBus connection is attempted and fails `psmouse_smbus_init`
> sets fast_reconnect to `psmouse_smbus_reconnect`.
> `psmouse_smbus_reconnect` expects `psmouse->private` to be
> `struct psmouse_smbus_dev` but `elantech_setup_ps2` replaces
> it with its private data. This was causing an issue on resume
> since psmouse_smbus_reconnect was being called while in ps2, not SMBus
> mode.
> 
> This was uncovered by commit 92e24e0e57f7 ("Input: psmouse - add delay when
> deactivating for SMBus mode")

Ahh, thx for investigating. This fixes things for me. Feel free to add:

Tested-by: Thorsten Leemhuis <linux@xxxxxxxxxxxxx>

> Closes:
> Link:https://lore.kernel.org/all/ca0109fa-c64b-43c1-a651-75b294d750a1@xxxxxxxxxxxxx/
> Reported-by: Thorsten Leemhuis <linux@xxxxxxxxxxxxx>

Side note: something went sideways here, it afaics should look something
like this:

"""
> Reported-by: Thorsten Leemhuis <linux@xxxxxxxxxxxxx>
> Closes:
https://lore.kernel.org/all/ca0109fa-c64b-43c1-a651-75b294d750a1@xxxxxxxxxxxxx/
"""

Thx again. Ciao, Thorsten