RE: Regression: devcoredump patch broke Realtek usb bluetooth adapter

[Max Chou]

Hi! Kirill,
I guess the root cause is as below.
===
static int btrtl_register_devcoredump_support(struct hci_dev *hdev)
{
        int err;

        err = hci_devcd_register(hdev, btrtl_coredump, btrtl_dmp_hdr, NULL);

        return err;
}
===
If CONFIG_DEV_COREDUMP is not enabled, it would return -EOPNOTSUPP for hci_devcd_register().
Unfortunately, btrtl_register_devcoredump_support() will return it. 
Finally, -EOPNOSTUPP will be returned for btrtl_setup_realtek().

Could you have the following workaround for the root cause checked?
Please share dmesg as well. Thanks,
===
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -967,8 +967,9 @@ static int btrtl_register_devcoredump_support(struct hci_dev *hdev)
        int err;

        err = hci_devcd_register(hdev, btrtl_coredump, btrtl_dmp_hdr, NULL);
+       rtl_dev_info(hdev, "%s(): err = %d", __func__, err);

-       return err;
+       return 0;
 }

 void btrtl_set_driver_name(struct hci_dev *hdev, const char *driver_name)
===

BRs,
Max


> -----Original Message-----
> From: Max Chou
> Sent: Wednesday, October 4, 2023 1:45 PM
> To: 'Kirill A. Shutemov' <kirill@xxxxxxxxxxxxx>
> Cc: Bagas Sanjaya <bagasdotme@xxxxxxxxx>; Hilda Wu
> <hildawu@xxxxxxxxxxx>; alex_lu@xxxxxxxxxxxxxx; Luiz Augusto von Dentz
> <luiz.von.dentz@xxxxxxxxx>; Marcel Holtmann <marcel@xxxxxxxxxxxx>;
> Johan Hedberg <johan.hedberg@xxxxxxxxx>; Juerg Haefliger
> <juerg.haefliger@xxxxxxxxxxxxx>; Linux Bluetooth
> <linux-bluetooth@xxxxxxxxxxxxxxx>; Thorsten Leemhuis <linux@xxxxxxxxxxxxx>;
> Linux Regressions <regressions@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List
> <linux-kernel@xxxxxxxxxxxxxxx>
> Subject: RE: Regression: devcoredump patch broke Realtek usb bluetooth
> adapter
> 
> Hi! Kirill,
> As your mentions, there's not obvious wrong from the dmesg.
> Could you capture btmon log with raw data? (btmon -w xxx.log) In additional,
> did you build the last version of bluetooth-next?
> By my understanding, you can just duplicate the issue by the commit
> "044014ce85a1 Bluetooth: btrtl: Add Realtek devcoredump support"?
> Unfortunately, I can not duplicate this issue sofar.
> 
> 
> BRs,
> Max
> 
> 
> > -----Original Message-----
> > From: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>
> > Sent: Wednesday, October 4, 2023 12:50 PM
> > To: Max Chou <max.chou@xxxxxxxxxxx>
> > Cc: Bagas Sanjaya <bagasdotme@xxxxxxxxx>; Hilda Wu
> > <hildawu@xxxxxxxxxxx>; alex_lu@xxxxxxxxxxxxxx; Luiz Augusto von Dentz
> > <luiz.von.dentz@xxxxxxxxx>; Marcel Holtmann <marcel@xxxxxxxxxxxx>;
> > Johan Hedberg <johan.hedberg@xxxxxxxxx>; Juerg Haefliger
> > <juerg.haefliger@xxxxxxxxxxxxx>; Linux Bluetooth
> > <linux-bluetooth@xxxxxxxxxxxxxxx>; Thorsten Leemhuis
> > <linux@xxxxxxxxxxxxx>; Linux Regressions
> > <regressions@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List
> > <linux-kernel@xxxxxxxxxxxxxxx>
> > Subject: Re: Regression: devcoredump patch broke Realtek usb bluetooth
> > adapter
> >
> >
> > External mail.
> >
> >
> >
> > On Wed, Oct 04, 2023 at 03:07:24AM +0000, Max Chou wrote:
> > > Hi! Kirill,
> > > I based on Kernel v6.5.5 and updated drivers/bluetooth to the last
> > > version of
> > bluetooth-next tree for a test with RTL8761BUV.
> > > The dmesg log and "hciconfig -a" are correct.
> > > Could you share the dmesg for your failure case?
> > >
> > > [56133.563293] usb 3-1: new full-speed USB device number 28 using
> > > xhci_hcd [56133.712559] usb 3-1: New USB device found,
> > > idVendor=0bda, idProduct=8771, bcdDevice= 2.00 [56133.712577] usb
> > > 3-1: New USB device
> > > strings: Mfr=1, Product=2, SerialNumber=3 [56133.712582] usb 3-1:
> > > Product: Bluetooth Radio [56133.712585] usb 3-1: Manufacturer:
> > > Realtek [56133.712588] usb 3-1: SerialNumber: 00E04C239987
> > > [56133.737812]
> > > usbcore: registered new interface driver btusb [56133.742126]
> > > Bluetooth: hci0: RTL: examining hci_ver=0a hci_rev=000b lmp_ver=0a
> > > lmp_subver=8761 [56133.743115] Bluetooth: hci0: RTL: rom_version
> > > status=0 version=1 [56133.743124] Bluetooth: hci0: RTL: loading
> > > rtl_bt/rtl8761bu_fw.bin [56133.743754] Bluetooth: hci0: RTL: loading
> > > rtl_bt/rtl8761bu_config.bin [56133.743829] Bluetooth: hci0: RTL:
> > > cfg_sz 6, total sz 30210 [56133.913311] Bluetooth: hci0: RTL: fw
> > > version 0xdfc6d922 [56133.980299] Bluetooth: MGMT ver 1.22
> > >
> > > hci0:   Type: Primary  Bus: USB
> > >         BD Address: 98:A2:35:85:56:F1  ACL MTU: 1021:6  SCO MTU:
> > 255:12
> > >         UP RUNNING
> > >         RX bytes:1670 acl:0 sco:0 events:184 errors:0
> > >         TX bytes:33917 acl:0 sco:0 commands:184 errors:0
> > >         Features: 0xff 0xff 0xff 0xfe 0xdb 0xfd 0x7b 0x87
> > >         Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3
> > >         Link policy: RSWITCH HOLD SNIFF PARK
> > >         Link mode: PERIPHERAL ACCEPT
> > >         Name: 'max-ThinkPad-X230'
> > >         Class: 0x6c010c
> > >         Service Classes: Rendering, Capturing, Audio, Telephony
> > >         Device Class: Computer, Laptop
> > >         HCI Version: 5.1 (0xa)  Revision: 0xdfc6
> > >         LMP Version: 5.1 (0xa)  Subversion: 0xd922
> > >         Manufacturer: Realtek Semiconductor Corporation (93)
> >
> > I don't see anything obviously wrong in dmesg. Attached hciconfig and
> > dmesg for both functional and broken cases.
> >
> > --
> >   Kiryl Shutsemau / Kirill A. Shutemov