Re: [PATCH net-next v4 05/18] net/smc: reserve CHID range for SMC-D virtual device

[Wen Gu]

On 2023/9/28 17:10, Alexandra Winter wrote:
> On 28.09.23 05:08, Jan Karcher wrote:
> > On 24/09/2023 17:16, Wen Gu wrote:
> > > This patch reserve CHID range from 0xFF00 to 0xFFFF for SMC-D virtual
> >
> > The current state is that 0xFF00 - 0xFFFF is the range of all virtual SMC-D devices. This range devides into:
> > - 0xFF00 - 0xFFFE is for virto-ism
> > - 0xFFFF is for loopback
> >
> >
> > > device and introduces helpers to identify them.
> > >
> > > Signed-off-by: Wen Gu <guwen@xxxxxxxxxxxxxxxxx>
> > > ---
> > >    net/smc/smc_ism.h | 15 +++++++++++++++
> > >    1 file changed, 15 insertions(+)
> > >
> > > diff --git a/net/smc/smc_ism.h b/net/smc/smc_ism.h
> > > index 14d2e77..2ecc8de 100644
> > > --- a/net/smc/smc_ism.h
> > > +++ b/net/smc/smc_ism.h
> > > @@ -15,6 +15,9 @@
> > >      #include "smc.h"
> > >    +#define SMC_VIRT_ISM_CHID_MAX        0xFFFF
> >
> > SMC_VIRT_ISM_MAX is 0xFFFE. Or do you mean virtual devices as the whole group. If yes i think that this naming will be very confusing in a few months/years.
> > Maybe something like SMC_VIRTUAL_DEV_CHID_{MIN|MAX}?
>
>
> IMO names are important. They can make future lives easier or harder.


Hi Sandy and Jan,

I agree with your opinion that names are important.

I view these terms in this way:

SMC-D devices (smcd_dev)
   |
   |- s390 ISM devices (ISM, ism_dev)
   |
   |- virtual ISM devices (virtual ISM, smc_lo_dev)
   |     |
   |     |- loopback-ism
   |     |
   |     |- virtio-ism
   |
   |- maybe future devices

SMC_VIRT_ISM_CHID_MAX was introduced to represent the maximum CHID of virtual ISM devices. CHIDs used
by virtual ISM devices should be in range of [SMC_VIRT_ISM_CHID_MIN, SMC_VIRT_ISM_CHID_MAX].

I think the problem here is that SMC_VIRT_ISM_CHID_MAX might be misunderstood as CHID of virtio-ism?
Then I will change them to SMC_VIRTUAL_ISM_CHID_{MAX|MIN}.

> Your first group of patches aims at 'decouple ISM device hard code from SMC-D stack'
> Maybe now would be a good point in time to decide what ISM should mean in net/smc.
> a) the s390 ISM devices
> b) SMC-D devices in general
> I would vote for a). (today a) and b) can be found in the code, as well as the term smcd_dev)
>
> Then like Jan wrote above:
> "0xFF00 - 0xFFFF is the range of all virtual SMC-D devices" and it should NOT be called SMC_VIRT_ISM_CHID_MAX.

Yes, I also vote for a).

But IMHO, loopback-ism and virtio-ism should be better classified as 'virtual ISM devices', like
what describes in the specification, rather than 'virtual SMC-D devices', since they are intended
to emulate ISM devices for using SMC-D on non-s390 systems.

> Then in many places in net/smc 'ism' should be replaces by 'smcd_dev' or something similar.
> Wen Gu, is that something you would offer to do as part of the preparation work for this series?

Yes. But I'm not sure which 'ism' words you suggested to be replaced with 'smcd_dev'/'smcd'?

IMHO, in some generic codes like SMC-D operations (smcd_ops) or SMC-D device dump, they should
be generic to all kinds of SMC-D devices, so struct ism_dev or struct ism_client should not be used,
that is what patch#1 & #2 want to do.

But in some operations related to underlay device, like smcd_ism_register_dmb(), smc_ism_cantalk(),
and etc in smc_ism.c. They works for both s390 ISM devices and virtual ISM devices. I think they can
keep 'ism' in the helpers' name as they are now.

What do you think?

Thanks and regards,
Wen Gu