Re: [RFC PATCH v2] mtd: nand: add support for ts72xx

[Miquel Raynal]

Hi Nikita,

nikita.shubin@xxxxxxxxxxx wrote on Wed,  4 Oct 2023 11:22:23 +0300:

> Technologic Systems has it's own nand controller implementation in CPLD.
> 
> Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
> ---
> Changelog v2:
> - dropped check for READCACHE
> - reordered Makefile
> 
> Link: https://lore.kernel.org/linux-mtd/20230926132725.5d570e1b@xps-13/T/#md7e5e944a6a08e24f4f1e20068a49f94794ab945
> ---

[...]

> +static int ts72xx_nand_exec_op(struct nand_chip *chip,
> +			       const struct nand_operation *op, bool check_only)
> +{
> +	unsigned int i;
> +	int ret;
> +

Missing:

	if (check_only)
		return 0;

LGTM otherwise.

Thanks,
Miquèl