Re: [PATCH V13 3/4] dt-bindings: mfd: qcom,tcsr: Add simple-mfd support for IPQ6018

[Krzysztof Kozlowski]

On 04/10/2023 11:04, Devi Priya wrote:
> Update the binding to include pwm as the child node to TCSR block and
> add simple-mfd support for IPQ6018.
> 
> Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx>
> ---

Thank you for your patch. There is something to discuss/improve.


>    reg:
>      maxItems: 1
>  
> +  ranges: true
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 1
> +
> +patternProperties:
> +  "pwm@[a-f0-9]+$":

type: object

> +    $ref: ../pwm/qcom,ipq6018-pwm.yaml

This should be full patch, so:
$ref: /schemas/pwm/qcom.......


> +
>  required:
>    - compatible
>    - reg

After required (but before additionalProperties), please add:

allOf:if:then: for other compatible (so use keyword "not:") which will
disallow pwm for them. Disallowing is via:

    patternProperties:
      "pwm@[a-f0-9]+$": false

See   Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml
around line 240. We need something similar.


> @@ -57,8 +74,29 @@ required:
>  additionalProperties: false
>  
>  examples:
> +  # Example 1 - Syscon node found on MSM8960
>    - |
>      syscon@1a400000 {
>          compatible = "qcom,tcsr-msm8960", "syscon";
>          reg = <0x1a400000 0x100>;
>      };
> +  # Example 2 - Syscon node found on IPQ6018
> +  - |
> +    #include <dt-bindings/clock/qcom,gcc-ipq6018.h>
> +
> +    syscon@1937000 {
> +        compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd";
> +        reg = <0x01937000 0x21000>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ranges = <0 0x1937000 0x21000>;

Please put ranges just after reg.

> +
> +        pwm: pwm@a010 {
> +            compatible = "qcom,ipq6018-pwm";
> +            reg = <0xa010 0x20>;

Best regards,
Krzysztof