Re: [PATCH v1 1/1] kernel.h: Move lib/cmdline.c prototypes to string.h

[Andy Shevchenko]

On Wed, Oct 4, 2023 at 2:39 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> On Tue, Oct 03, 2023 at 04:01:42PM +0300, Andy Shevchenko wrote:
> > The lib/cmdline.c is basically a set of some small string parsers
> > which are wide used in the kernel. Their prototypes belong to the
> > string.h rather then kernel.h.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> I think these should live in string_helpers.h not string.h (which is, in
> theory, supposed to be used for the standard C string library functions,
> though that's not 100% currently)...

These are being used in the early stages where usually we have
string.h. So, I would argue, but if you insist, I can move them. What
about lib/argv_slit.c then? Because semantically it's quite close to
what the lib/cmdline.c is doing.

-- 
With Best Regards,
Andy Shevchenko