Re: [PATCH 2/4] readv.2: Document RWF_ATOMIC flag

From: Bart Van Assche
Date: Wed Oct 04 2023 - 13:37:03 EST


On 10/4/23 01:47, John Garry wrote:
On 03/10/2023 20:25, Bart Van Assche wrote:
Additionally, shouldn't it be documented what value will be stored in
errno if the atomic write has been rejected?

So I was treating all atomic writes errors which don't follow the "rules" as low-level I/O errors, which is -EIO. However, yes, I can document this. Further to that, based on description of an error for O_DIRECT, which is to return -EINVAL for misaligned, I think that -EINVAL may be better for any atomic write rule violations. OK?

That sounds good to me.

Thanks,

Bart.