Re: [PATCH net] net: microchip: lan743x : bidirectional throughuput improvement

From: Jakub Kicinski
Date: Wed Oct 04 2023 - 16:10:02 EST


On Wed, 4 Oct 2023 13:02:17 -0700 Florian Fainelli wrote:
> > Nobody complained for 5 years, and it's not a regression.
> > Let's not treat this as a fix, please repost without the Fixes tag for
> > net-next.
>
> As a driver maintainer, you may want to provide some guarantees to your
> end users/customers that from stable version X.Y.Z the performance
> issues have been fixed. Performance improvements are definitively border
> line in terms of being considered as bug fixes though.

I understand that, but too often people just "feel like a device which
advertises X Mbps / Gbps should reach line rate" while no end user
cares.

Luckily stable rules are pretty clear about this (search for
"performance"):
https://docs.kernel.org/process/stable-kernel-rules.html

As posted it doesn't fulfill the requirements 🤷️