Re: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for dmaengine support

From: Jakub Kicinski
Date: Wed Oct 04 2023 - 16:41:11 EST


On Thu, 28 Sep 2023 01:02:30 +0530 Radhey Shyam Pandey wrote:
> */
> -static int axienet_open(struct net_device *ndev)
> +

nit: spurious new line

> +static inline int axienet_init_legacy_dma(struct net_device *ndev)

nit: no need for the inline, it has one caller and isn't on the fast
path