Re: [PATCH v2] firmware_loader: Abort new fw load request once firmware core knows about reboot
From: kernel test robot
Date: Wed Oct 04 2023 - 21:54:45 EST
Hi Mukesh,
kernel test robot noticed the following build errors:
[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on driver-core/driver-core-next driver-core/driver-core-linus linus/master v6.6-rc4 next-20231004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mukesh-Ojha/firmware_loader-Abort-new-fw-load-request-once-firmware-core-knows-about-reboot/20231004-225910
base: driver-core/driver-core-testing
patch link: https://lore.kernel.org/r/1696431327-7369-1-git-send-email-quic_mojha%40quicinc.com
patch subject: [PATCH v2] firmware_loader: Abort new fw load request once firmware core knows about reboot
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231005/202310050911.UHh53hem-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231005/202310050911.UHh53hem-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310050911.UHh53hem-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
In file included from drivers/base/firmware_loader/fallback.c:11:
In file included from drivers/base/firmware_loader/fallback.h:9:
drivers/base/firmware_loader/sysfs.h:87:20: error: redefinition of 'fw_load_abort' as different kind of symbol
static inline void fw_load_abort(struct fw_sysfs *fw_sysfs)
^
drivers/base/firmware_loader/firmware.h:89:13: note: previous definition is here
extern bool fw_load_abort;
^
>> drivers/base/firmware_loader/fallback.c:113:16: error: called object type 'bool' (aka '_Bool') is not a function or function pointer
fw_load_abort(fw_sysfs);
~~~~~~~~~~~~~^
2 errors generated.
--
In file included from drivers/base/firmware_loader/sysfs.c:9:
drivers/base/firmware_loader/sysfs.h:87:20: error: redefinition of 'fw_load_abort' as different kind of symbol
static inline void fw_load_abort(struct fw_sysfs *fw_sysfs)
^
drivers/base/firmware_loader/firmware.h:89:13: note: previous definition is here
extern bool fw_load_abort;
^
>> drivers/base/firmware_loader/sysfs.c:218:16: error: called object type 'bool' (aka '_Bool') is not a function or function pointer
fw_load_abort(fw_sysfs);
~~~~~~~~~~~~~^
drivers/base/firmware_loader/sysfs.c:302:16: error: called object type 'bool' (aka '_Bool') is not a function or function pointer
fw_load_abort(fw_sysfs);
~~~~~~~~~~~~~^
3 errors generated.
vim +113 drivers/base/firmware_loader/fallback.c
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 66
60fa74263cbeae1 drivers/base/firmware_loader/fallback.c Luis R. Rodriguez 2018-03-10 67 /**
c35f9cbb1df8f17 drivers/base/firmware_loader/fallback.c Andres Rodriguez 2018-05-10 68 * fw_load_sysfs_fallback() - load a firmware via the sysfs fallback mechanism
b93815d0f37e7c4 drivers/base/firmware_loader/fallback.c Andres Rodriguez 2018-04-25 69 * @fw_sysfs: firmware sysfs information for the firmware to load
60fa74263cbeae1 drivers/base/firmware_loader/fallback.c Luis R. Rodriguez 2018-03-10 70 * @timeout: timeout to wait for the load
60fa74263cbeae1 drivers/base/firmware_loader/fallback.c Luis R. Rodriguez 2018-03-10 71 *
60fa74263cbeae1 drivers/base/firmware_loader/fallback.c Luis R. Rodriguez 2018-03-10 72 * In charge of constructing a sysfs fallback interface for firmware loading.
60fa74263cbeae1 drivers/base/firmware_loader/fallback.c Luis R. Rodriguez 2018-03-10 73 **/
89287c169f8ff79 drivers/base/firmware_loader/fallback.c Kees Cook 2020-10-02 74 static int fw_load_sysfs_fallback(struct fw_sysfs *fw_sysfs, long timeout)
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 75 {
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 76 int retval = 0;
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 77 struct device *f_dev = &fw_sysfs->dev;
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 78 struct fw_priv *fw_priv = fw_sysfs->fw_priv;
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 79
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 80 /* fall back on userspace loading */
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 81 if (!fw_priv->data)
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 82 fw_priv->is_paged_buf = true;
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 83
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 84 dev_set_uevent_suppress(f_dev, true);
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 85
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 86 retval = device_add(f_dev);
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 87 if (retval) {
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 88 dev_err(f_dev, "%s: device_register failed\n", __func__);
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 89 goto err_put_dev;
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 90 }
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 91
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 92 mutex_lock(&fw_lock);
b30557dae4a363d drivers/base/firmware_loader/fallback.c Mukesh Ojha 2023-10-04 93 if (fw_load_abort || fw_state_is_aborted(fw_priv)) {
75d95e2e39b27f7 drivers/base/firmware_loader/fallback.c Anirudh Rayabharam 2021-07-28 94 mutex_unlock(&fw_lock);
75d95e2e39b27f7 drivers/base/firmware_loader/fallback.c Anirudh Rayabharam 2021-07-28 95 retval = -EINTR;
75d95e2e39b27f7 drivers/base/firmware_loader/fallback.c Anirudh Rayabharam 2021-07-28 96 goto out;
75d95e2e39b27f7 drivers/base/firmware_loader/fallback.c Anirudh Rayabharam 2021-07-28 97 }
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 98 list_add(&fw_priv->pending_list, &pending_fw_head);
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 99 mutex_unlock(&fw_lock);
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 100
89287c169f8ff79 drivers/base/firmware_loader/fallback.c Kees Cook 2020-10-02 101 if (fw_priv->opt_flags & FW_OPT_UEVENT) {
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 102 fw_priv->need_uevent = true;
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 103 dev_set_uevent_suppress(f_dev, false);
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 104 dev_dbg(f_dev, "firmware: requesting %s\n", fw_priv->fw_name);
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 105 kobject_uevent(&fw_sysfs->dev.kobj, KOBJ_ADD);
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 106 } else {
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 107 timeout = MAX_JIFFY_OFFSET;
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 108 }
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 109
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 110 retval = fw_sysfs_wait_timeout(fw_priv, timeout);
bcfbd3523f3c6ee drivers/base/firmware_loader/fallback.c Junyong Sun 2020-03-03 111 if (retval < 0 && retval != -ENOENT) {
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 112 mutex_lock(&fw_lock);
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 @113 fw_load_abort(fw_sysfs);
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 114 mutex_unlock(&fw_lock);
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 115 }
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 116
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 117 if (fw_state_is_aborted(fw_priv)) {
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 118 if (retval == -ERESTARTSYS)
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 119 retval = -EINTR;
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 120 } else if (fw_priv->is_paged_buf && !fw_priv->data)
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 121 retval = -ENOMEM;
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 122
75d95e2e39b27f7 drivers/base/firmware_loader/fallback.c Anirudh Rayabharam 2021-07-28 123 out:
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 124 device_del(f_dev);
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 125 err_put_dev:
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 126 put_device(f_dev);
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 127 return retval;
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 128 }
d73f821c7aea16a drivers/base/firmware_fallback.c Luis R. Rodriguez 2018-03-10 129
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki