RE: [PATCH] dt-bindings: arm: altera: convert socfpga-system.txt to yaml

[Rabara, Niravkumar L]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Wednesday, October 4, 2023 11:43 PM
> To: Rabara, Niravkumar L <niravkumar.l.rabara@xxxxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> Dinh Nguyen <dinguyen@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] dt-bindings: arm: altera: convert socfpga-system.txt to
> yaml
> 
> On 04/10/2023 12:32, Rabara, Niravkumar L wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> >> Sent: Wednesday, October 4, 2023 2:46 PM
> >> To: Rabara, Niravkumar L <niravkumar.l.rabara@xxxxxxxxx>; Rob Herring
> >> <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> >> <krzysztof.kozlowski+dt@xxxxxxxxxx>;
> >> Conor Dooley <conor+dt@xxxxxxxxxx>; Dinh Nguyen
> <dinguyen@xxxxxxxxxx>
> >> Cc: devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> >> Subject: Re: [PATCH] dt-bindings: arm: altera: convert
> >> socfpga-system.txt to yaml
> >>
> >> On 04/10/2023 05:07, niravkumar.l.rabara@xxxxxxxxx wrote:
> >>> From: Niravkumar L Rabara <niravkumar.l.rabara@xxxxxxxxx>
> >>>
> >>> Convert socfpga-system.txt to altr,sys-mgr.yaml.
> >>>
> >>> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@xxxxxxxxx>
> >>> ---
> >>>  .../bindings/arm/altera/altr,sys-mgr.yaml     | 50 +++++++++++++++++++
> >>>  .../bindings/arm/altera/socfpga-system.txt    | 25 ----------
> >>>  2 files changed, 50 insertions(+), 25 deletions(-)  create mode
> >>> 100644
> >>> Documentation/devicetree/bindings/arm/altera/altr,sys-mgr.yaml
> >>
> >> arm is only for top-level. What is this this device about? FPGA? SoC?
> >
> > This is for Altera SoCFPGA System Manager registers, common binding
> > file for ARM and ARM64 platforms.
> 
> So SoC part?

Yes

> 
> > Should I use  "altr,socfpga-sys-mgr.yaml" as per the naming conventions?
> >
> > Do you also suggest to move this yaml to different folder instead of "
> > Documentation/devicetree/bindings/arm/altera arm/altera/" ?
> 
> I am suggesting to move it to soc.

Alright, I will create a folder "altera" in soc directory and move it there in V2. 
Documentation/devicetree/bindings/soc/altera/altr,socfpga-sys-mgr.yaml

> 
> 
> Best regards,
> Krzysztof

Thanks,
Nirav