Re: [PATCH] nvmet-fc: Annotate struct nvmet_fc_tgt_queue with __counted_by

From: Christoph Hellwig
Date: Thu Oct 05 2023 - 10:48:05 EST


On Tue, Oct 03, 2023 at 04:25:11PM -0700, Kees Cook wrote:
> struct workqueue_struct *work_q;
> struct kref ref;
> struct rcu_head rcu;
> - struct nvmet_fc_fcp_iod fod[]; /* array of fcp_iods */
> + struct nvmet_fc_fcp_iod fod[] __counted_by(sqsize); /* array of fcp_iods */

Please move the comment up to not spill over the end of the line.

Otherwise this looks good.