Re: [syzbot] [integrity] [overlayfs] possible deadlock in mnt_want_write (2)

[Amir Goldstein]

On Thu, Oct 5, 2023 at 4:14 PM Mimi Zohar <zohar@xxxxxxxxxxxxx> wrote:
>
> On Thu, 2023-10-05 at 13:26 +0300, Amir Goldstein wrote:
> > On Thu, Oct 5, 2023 at 12:59 PM syzbot
> > <syzbot+b42fe626038981fb7bfa@xxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > Hello,
> > >
> > > syzbot tried to test the proposed patch but the build/boot failed:
> >
> > My mistake. Please try again:
> >
> > #syz test: https://github.com/amir73il/linux ima-ovl-fix
>
> Thanks, Amir.   "mutext_init(&iint->mutex); moved, but the status
> initialization lines 161-166 were dropped.   They're needed by IMA-
> appraisal for signature verification.
>
>         iint->ima_file_status = INTEGRITY_UNKNOWN;
>         iint->ima_mmap_status = INTEGRITY_UNKNOWN;
>         iint->ima_bprm_status = INTEGRITY_UNKNOWN;
>         iint->ima_read_status = INTEGRITY_UNKNOWN;
>         iint->ima_creds_status = INTEGRITY_UNKNOWN;
>         iint->evm_status = INTEGRITY_UNKNOWN;
>

They are dropped from iint_init_once()
They are not needed there because there are now set
in every iint allocation in iint_init_always()
instead of being set in iint_free()

This is the standard practice for slab objects.
See inode_init_once()/inode_init_always().

Thanks,
Amir.