Re: [PATCH v4 1/2] bpftool: Align output skeleton ELF code

From: Quentin Monnet
Date: Thu Oct 05 2023 - 12:11:50 EST


On 04/10/2023 23:23, Ian Rogers wrote:
> libbpf accesses the ELF data requiring at least 8 byte alignment,
> however, the data is generated into a C string that doesn't guarantee
> alignment. Fix this by assigning to an aligned char array. Use sizeof
> on the array, less one for the \0 terminator, rather than generating a
> constant.
>
> Fixes: a6cc6b34b93e ("bpftool: Provide a helper method for accessing skeleton's embedded ELF data")
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> Reviewed-by: Alan Maguire <alan.maguire@xxxxxxxxxx>

Acked-by: Quentin Monnet <quentin@xxxxxxxxxxxxx>

Thanks