Re: [PATCH 1/3] dt-bindings: regulator: regulator-output: Multiple supplies

From: Zev Weiss
Date: Thu Oct 05 2023 - 12:16:26 EST


On Thu, Oct 05, 2023 at 12:46:31AM PDT, Naresh Solanki wrote:
Hi Rob,


On Wed, 4 Oct 2023 at 20:44, Rob Herring <robh@xxxxxxxxxx> wrote:

On Wed, Oct 04, 2023 at 02:05:26PM +0200, Naresh Solanki wrote:
> Add support for multiple supplies.

Why?
1. Driver is already capable of that using platform data. Hence added
support to read DT property & initialize the same for multiple
supplies instead of being limited to one.
2. This is particularly useful in cases wherein 2 or more regulators
are coupled together, for example in a PCIe connector having 3.3V &
12V.


Hmm -- apologies if I pointed you in the wrong direction here on the last revision (or should have considered this earlier), but is there a particular need for this arrangement to be described by a single regulator-output DT node instead of just having one node per supply? If they're independently-controlled voltage outputs, treating them as two separate things instead of a single ganged one seems like it might be more appropriate anyway...


Zev