Re: [PATCH] gcov: Annotate struct gcov_iterator with __counted_by

From: Peter Oberparleiter
Date: Thu Oct 05 2023 - 12:43:52 EST


On 22.09.2023 19:52, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct gcov_iterator.
>
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

Looks good to me!

Reviewed-by: Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>

Andrew, could you add this patch via your tree?


--
Peter Oberparleiter
Linux on IBM Z Development - IBM Germany R&D