Re: [PATCHv2 next 1/3] ptp: add ptp_gettimex64any() support

From: Mahesh Bandewar (महेश बंडेवार)
Date: Thu Oct 05 2023 - 19:28:07 EST


On Tue, Oct 3, 2023 at 9:38 PM Richard Cochran <richardcochran@xxxxxxxxx> wrote:
>
> On Mon, Oct 02, 2023 at 09:17:01PM -0700, Mahesh Bandewar wrote:
> > add support for TS sandwich of the user preferred timebase. The options
> > supported are PTP_TS_REAL (CLOCK_REALTIME), PTP_TS_MONO (CLOCK_MONOTONIC),
> > and PTP_TS_RAW (CLOCK_MONOTONIC_RAW)
> >
> > Option of PTP_TS_REAL is equivalent of using ptp_gettimex64().
>
> This change log is horrible.
>
> Please write a proper explanation, and be sure to cover the following
> three points.
>
> 1. context
> 2. problem
> 3. solution
>
> Every change log must have those three items.
>
> In addition, this series needs a cover letter that clearly justifies
> the need for this change.
>
Fair point and the series does have a cover letter which you can
access it at https://lore.kernel.org/lkml/20231003041657.1745487-1-maheshb@xxxxxxxxxx/
Probably it's fault of my mailer-script which finds the reviewers for
individual patches by running scripts/get_maintainer.pl but then
coverletter is just sent to the mailing-list


> Thanks,
> Richard
>