Re: [PATCH 1/1] perf symbols: Add 'intel_idle_ibrs' to the list of idle symbols

[Namhyung Kim]

Hi Arnaldo,

On Thu, Oct 5, 2023 at 6:29 AM Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
>
> From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>
> This is a longstanding to do list entry: we need a way to see that a
> sample took place while in idle state, as the current way to do it is
> to infer that by the name of the functions that in such state have
> more samples, IOW: a hack.
>
> Maybe we can do flip a bit in samples that take place inside the
> enter/exit idle section in do_idle()?
>
> But till then, add one more :-\
>
> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> cc: Frédéric Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Ian Rogers <irogers@xxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>,
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks,
Namhyung


> ---
>  tools/perf/util/symbol.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index 5b54d2639df4740e..3c7f483bf85bbdaf 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -718,6 +718,7 @@ static bool symbol__is_idle(const char *name)
>                 "cpu_startup_entry",
>                 "idle_cpu",
>                 "intel_idle",
> +               "intel_idle_ibrs",
>                 "default_idle",
>                 "native_safe_halt",
>                 "enter_idle",
> --
> 2.41.0
>