Re: [PATCH v1 07/11] leds: aw200xx: add delay after software reset
From: Andy Shevchenko
Date: Fri Oct 06 2023 - 14:02:20 EST
On Fri, Oct 6, 2023 at 7:05 PM Dmitry Rokosov
<ddrokosov@xxxxxxxxxxxxxxxxx> wrote:
>
> From: George Stark <gnstark@xxxxxxxxxxxxxxxxx>
>
> According to datasheets of aw200xx devices software reset takes at
> least 1 ms so add delay after reset before issuing commands to device.
> + /* according to datasheet software reset takes at least 1ms */
Please, be consistent in all patches in all commit messages and code
comments on how you supply physical units (w/ space or w/o, take also
into consideration traditional scientific practices).
> + usleep_range(1000, 2000);
fsleep() ?
--
With Best Regards,
Andy Shevchenko