Re: [PATCH v8 00/12] cleanups and unit test for mballoc

[Theodore Ts'o]

On Fri, 29 Sep 2023 00:03:55 +0800, Kemeng Shi wrote:
> v7->v8:
> 1. Convert all ext4_mb_mark_bb to use bool in patch 1.
> 2. Improve commit msg as Ritesh suggested.
> 3. Collect RBs from Ritesh. A lot thanks to Ritesh!
> 
> v6->v7:
> 1. Remove struct ext4_mark_context and call ext4_mb_mark_context with all
> needed arguments directly.
> 2. Add new patch to make state in ext4_mb_mark_bb bool and make state in
> new-added function ext4_mb_mark_context bool.
> 3. Fix typos in git messages.
> 4. Keep on-disk bitmap marking code tight in patch separating on-disk
> bitmap and buddy bitmap freeing.
> 5. Test 64k blocksize instead of 256k blocksize.
> 6. Remove RVB from Ojaswin in changed patches and collect updated RVB from
> Ritesh.
> 7. As there is no much functional change to initial version, "kvm-xfstest
> smoke" test and kunit test are ran and result is good.
> 8. Plan to add ext4_inode_block_valid in ext4_mb_mark_context in new
> series!
> 
> [...]

Applied, thanks!

[01/12] ext4: make state in ext4_mb_mark_bb to be bool
        commit: d2f7cf40ea89b486fb7a25f5ab9a5d3ce26fb4bb
[02/12] ext4: factor out codes to update block bitmap and group descriptor on disk from ext4_mb_mark_bb
        commit: f9e2d95a45321857bd0397aa07ae30cc20f0988f
[03/12] ext4: call ext4_mb_mark_context in ext4_free_blocks_simple
        commit: 26d0f87b9fff37f9d4a04aa49f40b0d24502d2b1
[04/12] ext4: extend ext4_mb_mark_context to support allocation under journal
        commit: c431d3867e0a8258d1948408eb8297cdd2400e67
[05/12] ext4: call ext4_mb_mark_context in ext4_mb_mark_diskspace_used
        commit: 2f94711b098bc55285ac74aba2f2b83fd72b555f
[06/12] ext4: Separate block bitmap and buddy bitmap freeing in ext4_mb_clear_bb()
        commit: 33e728c67db6b7e72fc8d09f7a38f72302b8a98d
[07/12] ext4: call ext4_mb_mark_context in ext4_mb_clear_bb
        commit: 38b8f70cd28c6ad21192d82f271b9e32bdcb8600
[08/12] ext4: Separate block bitmap and buddy bitmap freeing in ext4_group_add_blocks()
        commit: 03c7fc39a677cdeae076d8b9ecc10920dd13f6a8
[09/12] ext4: call ext4_mb_mark_context in ext4_group_add_blocks()
        commit: 5c657db46d9ebc63e57be1408f1986c9b23368e1
[10/12] ext4: add some kunit stub for mballoc kunit test
        commit: bdefd689b7ff0eadc3b29dc6c66556617bd1ed42
[11/12] ext4: add first unit test for ext4_mb_new_blocks_simple in mballoc
        commit: 7c9fa399a369546c0e0375ea4b354d642a8fe501
[12/12] ext4: run mballoc test with different layouts setting
        commit: 28b95ee868072f1cd029245bf96cf02844322f37

Best regards,
-- 
Theodore Ts'o <tytso@xxxxxxx>