Re: [PATCH] fpga: altera-ps-spi: Use spi_get_device_match_data()

[Xu Yilun]

On Sat, Oct 07, 2023 at 03:43:41PM +0800, Xu Yilun wrote:
> On Fri, Oct 06, 2023 at 05:46:24PM -0500, Rob Herring wrote:
> > Use preferred spi_get_device_match_data() instead of of_match_device() and
> > spi_get_device_id() to get the driver match data. With this, adjust the
> > includes to explicitly include the correct headers.
> > 
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> 
> Acked-by: Xu Yilun <yilun.xu@xxxxxxxxx>
> 
> Applied.
> 
> >  
> >  static const struct spi_device_id altera_ps_spi_ids[] = {
> > -	{ "cyclone-ps-spi", CYCLONE5 },
> > -	{ "fpga-passive-serial", CYCLONE5 },
> > -	{ "fpga-arria10-passive-serial", ARRIA10 },
> > +	{ "cyclone-ps-spi", (uintptr_t)&c5_data },
> > +	{ "fpga-passive-serial", (uintptr_t)&c5_data },
> > +	{ "fpga-arria10-passive-serial", (uintptr_t)&a10_data },

Sorry, one more. Should cast to kernel_ulong_t?

Thanks,
Yilun

> >  	{}
> >  };
> >  MODULE_DEVICE_TABLE(spi, altera_ps_spi_ids);
> > -- 
> > 2.40.1
> >