Re: [PATCH] media: v4l2-event: Annotate struct v4l2_subscribed_event with __counted_by

From: Hans Verkuil
Date: Sat Oct 07 2023 - 05:21:37 EST


On 06/10/2023 22:28, Kees Cook wrote:
> On Fri, 22 Sep 2023 10:49:52 -0700, Kees Cook wrote:
>> Prepare for the coming implementation by GCC and Clang of the __counted_by
>> attribute. Flexible array members annotated with __counted_by can have
>> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
>> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
>> functions).
>>
>> As found with Coccinelle[1], add __counted_by for struct v4l2_subscribed_event.
>> Additionally, since the element count member must be set before accessing
>> the annotated flexible array member, move its initialization earlier.
>>
>> [...]
>
> Since this is a trivial change and it's been 2 week without further
> discussion, I'll snag this patch.

Ah, I picked this up for media as well. Same for the other patch.
You should have gotten an email from patchwork on Oct 3 that it was accepted.

I think I should be more pro-active and reply when I pick up patches from
non-media developers instead of relying on patchwork. It seems that it is
easy to miss emails from patchwork.

Regards,

Hans

>
> Applied to for-next/hardening, thanks!
>
> [1/1] media: v4l2-event: Annotate struct v4l2_subscribed_event with __counted_by
> https://git.kernel.org/kees/c/b1a20bbd4687
>
> Take care,
>