[PATCH 1/2] lib/bitmap: move bitmap allocators for device to linux/device.h
From: Yury Norov
Date: Sat Oct 07 2023 - 19:40:05 EST
The allocators are simple wrappers around bitmap_{alloc,free}().
So move them from bitmap to device sources.
Similarly to other device wrappers, turn them to static inlines
and place in header.
Signed-off-by: Yury Norov <yury.norov@xxxxxxxxx>
---
include/linux/bitmap.h | 8 --------
include/linux/device.h | 30 ++++++++++++++++++++++++++++++
lib/bitmap.c | 33 ---------------------------------
3 files changed, 30 insertions(+), 41 deletions(-)
diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
index 03644237e1ef..ce8fcd8736f1 100644
--- a/include/linux/bitmap.h
+++ b/include/linux/bitmap.h
@@ -11,8 +11,6 @@
#include <linux/string.h>
#include <linux/types.h>
-struct device;
-
/*
* bitmaps provide bit arrays that consume one or more unsigned
* longs. The bitmap interface and available operations are listed
@@ -125,12 +123,6 @@ unsigned long *bitmap_alloc_node(unsigned int nbits, gfp_t flags, int node);
unsigned long *bitmap_zalloc_node(unsigned int nbits, gfp_t flags, int node);
void bitmap_free(const unsigned long *bitmap);
-/* Managed variants of the above. */
-unsigned long *devm_bitmap_alloc(struct device *dev,
- unsigned int nbits, gfp_t flags);
-unsigned long *devm_bitmap_zalloc(struct device *dev,
- unsigned int nbits, gfp_t flags);
-
/*
* lib/bitmap.c provides these functions:
*/
diff --git a/include/linux/device.h b/include/linux/device.h
index 56d93a1ffb7b..01b8161b283a 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -435,6 +435,36 @@ struct device_dma_parameters {
unsigned long segment_boundary_mask;
};
+static inline void devm_bitmap_free(void *data)
+{
+ unsigned long *bitmap = data;
+
+ bitmap_free(bitmap);
+}
+
+static inline unsigned long *devm_bitmap_alloc(struct device *dev,
+ unsigned int nbits, gfp_t flags)
+{
+ unsigned long *bitmap;
+ int ret;
+
+ bitmap = bitmap_alloc(nbits, flags);
+ if (!bitmap)
+ return NULL;
+
+ ret = devm_add_action_or_reset(dev, devm_bitmap_free, bitmap);
+ if (ret)
+ return NULL;
+
+ return bitmap;
+}
+
+static inline unsigned long *devm_bitmap_zalloc(struct device *dev,
+ unsigned int nbits, gfp_t flags)
+{
+ return devm_bitmap_alloc(dev, nbits, flags | __GFP_ZERO);
+}
+
/**
* enum device_link_state - Device link states.
* @DL_STATE_NONE: The presence of the drivers is not being tracked.
diff --git a/lib/bitmap.c b/lib/bitmap.c
index ddb31015e38a..41f32fa3a80f 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -8,7 +8,6 @@
#include <linux/bitops.h>
#include <linux/bug.h>
#include <linux/ctype.h>
-#include <linux/device.h>
#include <linux/errno.h>
#include <linux/export.h>
#include <linux/kernel.h>
@@ -1415,38 +1414,6 @@ void bitmap_free(const unsigned long *bitmap)
}
EXPORT_SYMBOL(bitmap_free);
-static void devm_bitmap_free(void *data)
-{
- unsigned long *bitmap = data;
-
- bitmap_free(bitmap);
-}
-
-unsigned long *devm_bitmap_alloc(struct device *dev,
- unsigned int nbits, gfp_t flags)
-{
- unsigned long *bitmap;
- int ret;
-
- bitmap = bitmap_alloc(nbits, flags);
- if (!bitmap)
- return NULL;
-
- ret = devm_add_action_or_reset(dev, devm_bitmap_free, bitmap);
- if (ret)
- return NULL;
-
- return bitmap;
-}
-EXPORT_SYMBOL_GPL(devm_bitmap_alloc);
-
-unsigned long *devm_bitmap_zalloc(struct device *dev,
- unsigned int nbits, gfp_t flags)
-{
- return devm_bitmap_alloc(dev, nbits, flags | __GFP_ZERO);
-}
-EXPORT_SYMBOL_GPL(devm_bitmap_zalloc);
-
#if BITS_PER_LONG == 64
/**
* bitmap_from_arr32 - copy the contents of u32 array of bits to bitmap
--
2.39.2