Re: [PATCH 1/2] lib/bitmap: move bitmap allocators for device to linux/device.h
From: Greg Kroah-Hartman
Date: Sun Oct 08 2023 - 01:19:18 EST
On Sat, Oct 07, 2023 at 04:35:09PM -0700, Yury Norov wrote:
> The allocators are simple wrappers around bitmap_{alloc,free}().
> So move them from bitmap to device sources.
No, they belong in the bitmap.h file, as they are devm_* versions of the
same functions in this file. They don't belong in the device.h file.
> Similarly to other device wrappers, turn them to static inlines
> and place in header.
Why do these need to be inline functions?
thanks,
greg k-h