Re: [PATCH v13 08/10] arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280
From: Krzysztof Kozlowski
Date: Sun Oct 08 2023 - 07:23:33 EST
On 08/10/2023 13:21, Krishna Kurapati PSSNV wrote:
>
>
> On 10/8/2023 4:41 PM, Krzysztof Kozlowski wrote:
>> On 07/10/2023 17:48, Krishna Kurapati wrote:
>>> Add USB and DWC3 node for tertiary port of SC8280 along with multiport
>>> IRQ's and phy's. This will be used as a base for SA8295P and SA8295-Ride
>>> platforms.
>>>
>>> Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx>
>>> ---
>>> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 84 ++++++++++++++++++++++++++
>>> 1 file changed, 84 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>>> index cad59af7ccef..5f64f75b07db 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>>> @@ -3330,6 +3330,90 @@ system-cache-controller@9200000 {
>>> interrupts = <GIC_SPI 582 IRQ_TYPE_LEVEL_HIGH>;
>>> };
>>>
>>> + usb_2: usb@a4f8800 {
>>> + compatible = "qcom,sc8280xp-dwc3-mp", "qcom,dwc3";
>>
>> There is no such compatible. Scrolling through 3 pages of cover letter,
>> I did not find dependency listed. I did not scroll more - dependency is
>> the most important piece, so I would assume it is in the top-part.
>>
> Hi Krzysztof,
>
> I rebased the series on top of latest usb-next. I mentioned in cover
> letter that the first 3 patches have been merged on usb-next and this
> series has the remaining 10 patches. Apologies, I must have mentioned
> commit number of the merged patches as well for better context. The
> compatible was merged in the patch [1].
OK, I see it now in latest next.
Best regards,
Krzysztof