Re: [PATCH 3/3] arm64: dts: rockchip: Add Turing RK1 SoM support

[Heiko Stübner]

Hi Sam,

Am Samstag, 7. Oktober 2023, 06:36:00 CEST schrieb Sam Edwards:
> The Turing RK1 is an upcoming RK3588-based SoM from Turing Machines,
> designed on the Jetson SO-DIMM form factor and meant to be compatible
> with most Jetson carrier boards (but especially the Turing Pi 2 cluster
> board from the same vendor). It has the typical I/O you'd expect from
> a Jetson board, including:
> 
> - Two UARTs (UART9 for console, UART2 is auxiliary)
> - PCI Express (2.0 x1 + 3.0 x4)
> - Gigabit Ethernet
> - On-board eMMC
> - PWM fan w/ tach
> - USB-OTG [1]
> - HDMI and MIPI DSI [1]
> - Miscellaneous external GPIO, I²C, SPI lines [1]
> 
> Beyond that, it is pretty similar to the RK3588 EVB (in terms of PMICs,
> RTC, etc).
> 
> This patch introduces a devicetree to enable most[1] of the SoM I/O.
> 
> [1] These peripherals are not addressed with this patch.
> 
> Signed-off-by: Sam Edwards <CFSworks@xxxxxxxxx>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../boot/dts/rockchip/rk3588-turing-rk1.dts   | 627 ++++++++++++++++++

This is more a general concern. You're introducing the rk1 as a dts file
but the from looking at the module-page and your patch description
this is "just" a SOM that most likely cannot run without some sort of carrier
board.

In the rockchip devicetree directory you can see a number of som boards
as som-dtsi + base-board forming a full product. Simply because the number
of usable peripherals will highly depend on what baseboard is used.

Thanks
Heiko