Re: [PATCH v1] perf test: Avoid system wide when not privileged
From: Namhyung Kim
Date: Mon Oct 09 2023 - 01:24:43 EST
On Mon, Oct 2, 2023 at 10:10 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> On Mon, Oct 2, 2023 at 9:47 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> >
> > Hi Ian,
> >
> > On Fri, Sep 29, 2023 at 11:02 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> > >
> > > Switch the test program to sleep that makes more sense for system wide
> > > events. Only enable system wide when root or not paranoid. This avoids
> > > failures under some testing conditions like ARM cloud.
> > >
> > > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> >
> > While I'm ok with the change, I wonder why it doesn't have the same
> > code structure as in the stat_all_metrics.sh which checks the actual result.
> >
> > Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>
>
> The metric group isn't printed when we print the metrics within it.
> This could be changed.
Ok, we can change it later. Applied to perf-tools-next, thanks!