RE: [EXT] Re: [PATCH net v2] octeontx2-pf: Fix page pool frag allocation failure.

From: Ratheesh Kannoth
Date: Mon Oct 09 2023 - 05:47:50 EST


> From: Yunsheng Lin <linyunsheng@xxxxxxxxxx>
> Subject: [EXT] Re: [PATCH net v2] octeontx2-pf: Fix page pool frag allocation
> failure.


> interface is configured with higher rx buffer size?
> ^^^^
What is the issue here ? English ?


> > + sz = ALIGN(SKB_DATA_ALIGN(buf_size), OTX2_ALIGN);
>
> Is the above really needed if PAGE_SIZE is bigger than SMP_CACHE_BYTES or
> OTX2_ALIGN? Doesn't get_order() already ensure that the alignment is
> bigger than SMP_CACHE_BYTES or OTX2_ALIGN?
Yes. It will ensure with current values. But being OXT2_ALIGN and SK_DATA_ALIGN are macros, why don’t we
Ensure the alignment, using the ALIGN().

-Ratheesh