Re: [PATCH/RFC] m68k: Add full preempt support

From: John Paul Adrian Glaubitz
Date: Mon Oct 09 2023 - 07:46:09 EST


Hi Geert!

On Mon, 2023-10-09 at 13:29 +0200, Geert Uytterhoeven wrote:
> On Fri, Oct 6, 2023 at 4:49 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > Currently, a Preemptible Kernel is only supported on the Coldfire CPU
> > family. Extend preempt support to the full Classic M68K CPU family
> > (68020+ with MMU, and 68000-derivatives without MMU).
> >
> > Make sure preemption is disabled in loops involving cache and TLB
> > flushing.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > ---
> > Tested on ARAnyM, using none/voluntary/full preemption.
>
> bloat-o-meter summaries for atari_defconfig:
>
> PREEMPT_NONE -> PREEMPT_VOLUNTARY:
>
> add/remove: 0/0 grow/shrink: 238/30 up/down: 2804/-748 (2056)
> Total: Before=4478149, After=4480205, chg +0.05%
>
> PREEMPT_VOLUNTARY -> PREEMPT:
>
> add/remove: 735/277 grow/shrink: 3050/347 up/down: 244359/-11440 (232919)
> Total: Before=4480205, After=4713124, chg +5.20%
>
> Ouch.

What exactly does the change document? More scheduling events?

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913