Re: [PATCH 2/8] phy: qcom: Introduce Super-Speed USB UNIPHY driver

[Praveenkumar I]

On 10/7/2023 5:27 AM, Konrad Dybcio wrote:
> On 3.10.2023 16:54, Dmitry Baryshkov wrote:
> > On Tue, 3 Oct 2023 at 17:22, Praveenkumar I <quic_ipkumar@xxxxxxxxxxx> wrote:
> > > On 9/30/2023 10:48 PM, Dmitry Baryshkov wrote:
> > > > On 29/09/2023 11:42, Praveenkumar I wrote:
> > > > > Adds Qualcomm 22ull Super-Speed USB UNIPHY driver support which
> > > > > is present in Qualcomm IPQ5332 SoC. This PHY is interfaced with
> > > > > SNPS DWC3 USB and SNPS DWC PCIe. Either one of the interface
> > > > > can use the it and selection is done via mux present in TCSR
> > > > > register. This driver selects the PHY for DWC3 USB and handles
> > > > > the reset, clocks and regulator.
> > > > >
> > > > > Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> > > > > ---
> > > > >    drivers/phy/qualcomm/Kconfig               |  11 +
> > > > >    drivers/phy/qualcomm/Makefile              |   1 +
> > > > >    drivers/phy/qualcomm/phy-qcom-uniphy-usb.c | 322 +++++++++++++++++++++
> > > > >    3 files changed, 334 insertions(+)
> > > > >    create mode 100644 drivers/phy/qualcomm/phy-qcom-uniphy-usb.c
> > > > >
> > > > > diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig
> > > > > index d891058b7c39..7257c8455c53 100644
> > > > > --- a/drivers/phy/qualcomm/Kconfig
> > > > > +++ b/drivers/phy/qualcomm/Kconfig
> > > > > @@ -154,6 +154,17 @@ config PHY_QCOM_M31_USB
> > > > >          management. This driver is required even for peripheral only or
> > > > >          host only mode configurations.
> > > > >    +config PHY_QCOM_UNIPHY_USB
> > > > > +    tristate "Qualcomm USB Super-Speed UNIPHY driver"
> > > > Can we please have more specific driver name? As I wrote earlier,
> > > > there are two other (different) kinds of Qualcomm UNI PHY devices:
> > > > - DSI / HDMI UNIPHY on apq8064 / msm8974 / msm8960 (?)
> > > > - USB QMP UNI PHY drivers
> > > >
> > > > Adding a driver called UNIPHY, which is not related to those two kinds
> > > > sounds pretty confusing to me.
> > > This UNIPHY is different from above mentioned ones. This a custom
> > > version for 22nm on Qualcomm IPQ5332.
> > > Can we name the driver as phy-qcom-uniphy-usb-ss-22ull.c /
> > > phy-qcom-usb-ss-22ull.c ?
> > usb-ss-22ull sounds better. Or maybe usb-ipq-ss
> usb-ipq-ss is as safe as usb-msm-ss
>
> We can not rely on the hardware never ever changing down the
> product line :D
Not all IPQ platforms having this UNIPHY. Only IPQ5332 and IPQ5018 are 
having
this custom version of UNIPHY. Hence thought usb-ipq-ss might confuse.
> Konrad
--
Thanks,
Praveenkumar