Re: [PATCH linux-next 1/3] sched/psi: Change update_triggers() to a void function

From: Ingo Molnar
Date: Mon Oct 09 2023 - 08:48:37 EST



* yang.yang29@xxxxxxxxxx <yang.yang29@xxxxxxxxxx> wrote:

> From: Yang Yang <yang.yang29@xxxxxxxxxx>
>
> Update_triggers() always return now + group->rtpoll_min_period, and the
> return value is only used by psi_rtpoll_work(), so change update_triggers()
> to a void function, let group->rtpoll_next_update = now +
> group->rtpoll_min_period directly.
> This will avoid unnecessary function return value passing.
>
> Signed-off-by: Yang Yang <yang.yang29@xxxxxxxxxx>
> Suggested-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>
> Suggested-by: Ingo Molnar <mingo@xxxxxxxxxx>

Thanks for the split-up!

I'll remove the Suggested-by tags you added for me: I didn't suggest the
changes themselves, only the split-up, which isn't credit-worthy :-)

Thanks,

Ingo