Re: [PATCH 3/7] dt-bindings: media: Document STM32MP25 VENC video encoder

From: Hugues FRUCHET
Date: Mon Oct 09 2023 - 09:07:02 EST


Hi Rob,

On 10/6/23 18:27, Rob Herring wrote:
On Wed, Oct 04, 2023 at 06:41:09PM -0500, Adam Ford wrote:
On Wed, Oct 4, 2023 at 4:16 AM Hugues Fruchet
<hugues.fruchet@xxxxxxxxxxx> wrote:

Add STM32MP25 VENC video encoder bindings.

Signed-off-by: Hugues Fruchet <hugues.fruchet@xxxxxxxxxxx>
---
.../bindings/media/st,stm32mp25-venc.yaml | 56 +++++++++++++++++++
1 file changed, 56 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/st,stm32mp25-venc.yaml

diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-venc.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-venc.yaml
new file mode 100644
index 000000000000..c69e0a34f675
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/st,stm32mp25-venc.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/st,stm32mp25-venc.yaml#

Can this dt-binding be made more generic, like something like
hantro-h1 or VC8000NanoE?

I think there will be more boards that may incorporate the Hantro-H1
or a VC8000 in the future, because I don't think this IP is unique to
the STM32MP25.

Unless the underlying IP is well documented (i.e. public), then it's
kind of pointless. Everyone will just invent their own numbers and names
of clocks, resets, etc. unless someone can enforce not doing that.

Unfortunately the IP documentation is not public, there are no documents provided publicly by Verisilicon for the time being.


Rob

BR,
Hugues