Re: [PATCH 2/4] mm: make vma_merge() and split_vma() internal

From: Vlastimil Babka
Date: Mon Oct 09 2023 - 11:45:33 EST


On 10/8/23 22:23, Lorenzo Stoakes wrote:
> Now the vma_merge()/split_vma() pattern has been abstracted, we use it

"it" refers to split_vma() only so "the latter" or "split_vma()"?

> entirely internally within mm/mmap.c, so make the function static. We also
> no longer need vma_merge() anywhere else except mm/mremap.c, so make it
> internal.
>
> In addition, the split_vma() nommu variant also need not be exported.
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@xxxxxxxxx>

Reviewed-by: Vlastimil Babka <vbabka@xxxxxxx>