[PATCH v3 12/18] perf svghelper: Avoid memory leak

From: Ian Rogers
Date: Mon Oct 09 2023 - 14:40:29 EST


On success path the sib_core and sib_thr values weren't being
freed. Detected by clang-tidy.

Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
---
tools/perf/util/svghelper.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/svghelper.c b/tools/perf/util/svghelper.c
index 0e4dc31c6c9c..1892e9b6aa7f 100644
--- a/tools/perf/util/svghelper.c
+++ b/tools/perf/util/svghelper.c
@@ -754,6 +754,7 @@ int svg_build_topology_map(struct perf_env *env)
int i, nr_cpus;
struct topology t;
char *sib_core, *sib_thr;
+ int ret = -1;

nr_cpus = min(env->nr_cpus_online, MAX_NR_CPUS);

@@ -799,11 +800,11 @@ int svg_build_topology_map(struct perf_env *env)

scan_core_topology(topology_map, &t, nr_cpus);

- return 0;
+ ret = 0;

exit:
zfree(&t.sib_core);
zfree(&t.sib_thr);

- return -1;
+ return ret;
}
--
2.42.0.609.gbb76f46606-goog