Re: [PATCH net-next v5 12/16] net: Replace hwtstamp_source by timestamping layer

[Florian Fainelli]

On 10/9/23 08:51, Köry Maincent wrote:
> From: Kory Maincent <kory.maincent@xxxxxxxxxxx>
>
> Replace hwtstamp_source which is only used by the kernel_hwtstamp_config
> structure by the more widely use timestamp_layer structure. This is done
> to prepare the support of selectable timestamping source.
>
> Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> ---
[snip]
>    * Prefer using this structure for in-kernel processing of hardware
>    * timestamping configuration, over the inextensible struct hwtstamp_config
> @@ -33,7 +28,7 @@ struct kernel_hwtstamp_config {
>   	int rx_filter;
>   	struct ifreq *ifr;
>   	bool copied_to_user;
> -	enum hwtstamp_source source;

It would be kind of nice to keep using the enum internally such that we 
can catch unhandled values, which the compiler is usually quite good at 
figuring.
--
Florian

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature