Re: [PATCH 1/4] mm: make __access_remote_vm() static

From: Jason Gunthorpe
Date: Mon Oct 09 2023 - 18:16:37 EST


On Sun, Oct 01, 2023 at 05:00:02PM +0100, Lorenzo Stoakes wrote:
> access_remote_vm() passes through parameters to __access_remote_vm()
> directly, so remove the __access_remote_vm() function from mm.h aand use
> access_remote_vm() in the one caller that needs it (ptrace_access_vm()).
>
> This allows future adjustments to the GUP-internal __access_remote_vm()
> function while keeping the access_remote_vm() function stable.
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@xxxxxxxxx>
> ---
> include/linux/mm.h | 2 --
> kernel/ptrace.c | 2 +-
> mm/memory.c | 4 ++--
> mm/nommu.c | 4 ++--
> 4 files changed, 5 insertions(+), 7 deletions(-)

Why do we even have two versions?

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason