Re: [PATCH linux-next 2/3] sched/psi: Avoid update triggers and rtpoll_total when it is unnecessary

From: yang.yang29
Date: Mon Oct 09 2023 - 22:12:24 EST


> I think that the second part could have been done in the first patch
> to place the "group->rtpoll_next_update = now +
> group->rtpoll_min_period" line at the right place from the beginning.

Thanks for your advice, if we strict follow "one conceptual change per patch"
rule, I think "group->rtpoll_next_update = ..." should be in another patch.

> Also when posting the next version please add the version number to
> all the patch titles in the patchset, not only to the cover letter.
> That helps with finding the latest version.
> Thanks!

Get it, thanks to your reminder. I treat the split-up patches as new patches
previously, so didn't add the version number. I will add version number in
follow-up patches.

> One small comment above and when you post the V2 please include
> peterz@xxxxxxxxxxxxx. Peter is hosting PSI in his tree, so he is the
> maintainer you absolutely need :)

I get the maintainer information from get_maintainer.pl, it said Peter is
a reviewer, maybe get_maintainer.pl should update ?
Johannes Weiner <hannes@xxxxxxxxxxx> (maintainer:PRESSURE STALL INFORMATION (PSI))
Suren Baghdasaryan <surenb@xxxxxxxxxx> (maintainer:PRESSURE STALL INFORMATION (PSI))
Peter Ziljstra <peterz@xxxxxxxxxxxxx> (reviewer:PRESSURE STALL INFORMATION (PSI))